-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for test for old IE versions #196
Conversation
… are either missed or have different set of properties (e.g. into test environments or into browser addons). Fixes #177
@FlyingDR Does JSDOM work 😛 ? And please sign the CLA if it is buggy close and reopen the PR |
@michael-ciniawsky No idea about JSDOM, never had experience with it. Maybe @frodare can help with testing this change with JSDOM? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess ideally we would figure out a way to run style-loader against Browserstack but that's another PR.
@FlyingDR Alright nevermind then 😛 |
@FlyingDR this PR does fix the issue for our JSDOM testing environment. |
@FlyingDR Thx 😛 |
What kind of change does this PR introduce?
Bugfix for #177
Did you add tests for your changes?
Change is only testable in a browsers, code itself was tested using Browserstack into whole range of IE versions across all versions of Windows starting from XP and into outdated / actual versions of all browsers on Windows / OS X / Android / iOS / Windows Phone.
If relevant, did you update the README?
Doesn't seems to be relevant
Summary
Test for old IE versions is updated to avoid blind accessing properties of global objects that may not be available into certain real environments (examples are here and here). Since the whole purpose of this test is about giving positive result for old IE versions (<=IE9) it can be safely updated with a test that is specifically targeted to these versions and doesn't tries to get deeper into (potentially missing) properties of globals.
Does this PR introduce a breaking change?
No